#561 YAML validation tests #691
Conversation
|
I've added wrong comment, this PR is actually for #570 |
|
Thanks, I'll find someone to review this PR soon |
|
@longtimeago help us to review this |
|
@krzyk Are you sure that all 3 phases (merge, deploy, release) are mandatory? I didn't found any doc about that |
|
@longtimeago @krzyk nothing is mandatory in the configuration. everything is optional. |
|
@longtimeago I've changed the tests to fail if merge/deploy/release contains just a list instead of script and/or env element |
|
@krzyk Now it looks good, thanks! |
|
@rultor Please, merge |
@longtimeago Thanks for your request. @yegor256 Please confirm this. |
| @@ -16,6 +16,7 @@ architect: | |||
| install: | | |||
| sudo apt-get install bsdmainutils | |||
| sudo gem install pdd | |||
| sudo gem install kwalify | |||
There was a problem hiding this comment.
what this is for? it's not used anywhere in the code below
There was a problem hiding this comment.
This just a help for the future implementer of todos, AFAIR rultor doesn't take into account .rultor.yml from PR during the build, just the one from master, has this changed?
There was a problem hiding this comment.
That's true, but once we merge this pull request, gem kwalify will be in master. Tasks/branches should be completely isolated. There is no guarantee that we will continue working on this problem after your pull request is merged. Maybe we will close the project right after. And the question will be - what this kwalify is doing here?
|
@krzyk don't you think that this functionality is bloating |
|
@yegor256 I was thinking of implementing validation in another class during the work on |
|
@krzyk but there is no guarantee that these TODO will be assigned to you. most probably they won't. and other developers won't know your ideas. so, either document your intention explicitly in TODO's or create a new |
|
@yegor256 please see the update |
|
@rultor good to merge |
|
@longtimeago 30 mins sent to your balance (ID |
|
@rultor deploy |
@alex-palevsky OK, I'll try to deploy now. You can check the progress here |
@alex-palevsky Done! FYI, the full log is here (took me 8min) |
No description provided.